-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added image crop ToSVG support #4738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs some test anyway |
Merged
i miss referenced and corrected later. :(
…On 19 Feb 2018 11:14 am, "Kevin Hsiao" ***@***.***> wrote:
Hi, I saw you referenced the #4736
<#4736> to #4738
<#4738>. But I don't see the
connections between cropping image and scaling it. Do you mind sort of
explaining for a little bit, thanks a lot!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4738 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABI4QKXonBI61tD-UHkUxVAZ_GlZv3Jjks5tWUlzgaJpZM4SJwFX>
.
|
second line doesn't seem to be correct |
yep is not. |
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* added svg crop support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4708
Add a clipPath to image toSVG in order to make crop working