fix(itext): fix bug that IME can not be inputted #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Looks good also to me. It could avoid to switch all the text input as planned. Can we pull after 1.6.0 release? I would be scared of another 0 day bug after release. |
|
@abruzzihraig can you fix the lint errors? ( variable e declared but not used in the events you added ). |
Merged
|
Proven to be usefull also for managing accents on some configurations. |
|
I leave a note: check if thos compositioncheck is also usefull when using arrows on some japanes input methods |
|
Is this fix included 1.6.0 release? I still can see this issue in http://fabricjs.com/kitchensink |
|
something brougth the issue back. i hope on the weekend i can clear something out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2473
Fabric.js does not support IME input, it is looks weird especially in Chinese input.
The reason is fabric just listen the event
oninput, and calculate a diff between the last two text, then inserts those new chars. The key is It doesn't have a reducing logic here.For example, when you type Chinese text with any IME, the previous result may looks like
xxxnanrenwangxxx, but the next you will gotxxx男人王xxxafter entered a return button. Note the length of the chars reduce from 16 to 9, but there is no reducing logic in onInput handler.So I use the events
compositionstartandcompositionendto check if users are using IME and prevent any insertion before they ended IME typing.