Restore green check on tests

[asturur]

Attempt to fix group transformMatrix test on isTransparent function.

[asturur]

#2624 was ok, #2632 no more. In the middle there is #2625 that i try to rebuild but is not possible to do anymore but it was ok.

[asturur]

I really cannot get what is happening here. It looks like it is not drawing. May it be an async issue? i also tried to disable retina scaling for the canvas test thinking that window.pixelRatio may have some strange value.

[asturur]

https://ide.c9.io/asturur/nodefabric-nodecanvas

@inssein @kangax i put up this example of this problem in nodejs on cloud9.

I'm trying to figure out this failing test. In browser is not failing, it renders correctly.

If i use toDataUrl i get just blank images.

Transparency test is working before apply trasformMatrix ( as expected ), after the pixels i expect to be transparents are not.

getImageData looks ok, toDataUrl not.

Anyone willing to get a look at it?

[asturur]

@inssein you look experienced with nodejs + fabricjs, i'm not.
Any hint on what is happening here?

[asturur]

@jhundley9109 you are welcome to continue here.

[jhundley9109]

I think I have figured out the problem. There are two issues on the head commit that need fixed. In renderAll for static canvas from commit 8082dae canvasToDrawOn.restore() is extra and I think it can be removed. Additionally in __toDataURL, from commit 520e8e6 var canvasEl = this.upperCanvasEl || this.lowerCanvasEl, was switched to var canvasEl = this.lowerCanvasEl,. I don't know exactly how this works, but switching that line to var canvasEl = this.contextContainer.canvas fixed the problem.

Doing both of these changes fixed the toDataURL on node. Since I don't really know the downstream effects of changing that to use the contextContainer.canvas, you guys should review. Let me know what you think.

[asturur]

I will check personally because i wanna close this story.

[asturur]

@kangax would you merge this please?
We have fixed tests and confirmed that toDataUrl has problems.

I'm working on toDataUrl problem but i would like to check again all the PRs with green marks asap.

[kangax]

Hm, why the failures?

[asturur]

What failures? The one before the last?