fabric.Group initialize does not pass options to fabric.Object superclass

[lorenzopolidori]

fabric.Group.prototype.initialize calls this.callSuper('initialize') instead of this.callSuper('initialize', options), effectively preventing any proper initialization of the object done by fabric.Object.prototype.initialize. Instead, it merely (and blindly) adds all options properties to the prototype with extend(this, options). Is this an intentional behavior for some reason?

I am especially thinking about all properties that need a proper initialization (e.g. 'gradient' and 'shadow') rather than simply being added to the Group prototype. More generally, any property that needs a special initialization which is implemented in fabric.Object should be initialized the same way for fabric.Group.

I suppose calling this.callSuper('initialize', options) and removing extend(this, options) would fix this problem (see an an example fabric.Image).

The same applies to fabric.Group.prototype._set which overrides fabric.Object.prototype._set. To properly initialize all properties defined in fabric.Object, this.callSuper('_set', key, value) should be called instead of this[key] = value;.

[kangax]

Is this an intentional behavior for some reason?

I don't recall at a moment but if you could update and test things out that would be great!

[lorenzopolidori]

Ok, I'll have a look when I have a bit of time.
On 27 Oct 2013 18:23, "Juriy Zaytsev" [email protected] wrote:

Is this an intentional behavior for some reason?

I don't recall at a moment but if you could update and test things out
that would be great!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/926#issuecomment-27175519
.

[inssein]

Are there any updates on this? I am creating a custom element extending a group and seem to be having lots of group related issues (such as the group moving, but the contents staying put).

[asturur]

I think this never went in, right?

[kangax]

Hm, you're right; looks like it didn't. I'll merge PR now if you send it ;)

[asturur]

Looks like a good offer :)

[asturur]

#1868