Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular object controls (corners) #885

Closed
cskwg opened this issue Oct 1, 2013 · 10 comments
Closed

Circular object controls (corners) #885

cskwg opened this issue Oct 1, 2013 · 10 comments

Comments

@cskwg
Copy link

cskwg commented Oct 1, 2013

For my current projec, fabric had to be slightly modified to allow round corners and to distinguish cornerColor and cornerFill. The reason was to make it more appealing for touch devices.
May I submit the complete file, so that somebody may integrate the changes into the source? It is a version 1.3.7 with a handfull of changes.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@kangax
Copy link
Member

kangax commented Oct 1, 2013

Which rounded corners are you talking about? Can you please show a simple demo?

FWIW, we already support round corners on fabric.Rect.

@kangax
Copy link
Member

kangax commented Oct 3, 2013

Closing until we have more info on this

@kangax kangax closed this as completed Oct 3, 2013
@cskwg
Copy link
Author

cskwg commented Oct 3, 2013

Its is about the corners, the grips of objects. The cornerColor property already exists, cornerFill is new.
I'd prefer to send the complete file to your team, so that you can merge the changes.

@cskwg
Copy link
Author

cskwg commented Oct 3, 2013

Ah, and the rounded corners relate to the grips as well. These usually are square. I added a function to draw round grips, so that they look nicer on touch devices.

@cskwg
Copy link
Author

cskwg commented Oct 3, 2013

It would also be nice to have a center grip to make moving objects easier with touch devices. This has not been done, yet, it is a feature request. But I will implement it if nobody else comes first and I find the time before our next release.

@somecodemonkey
Copy link
Contributor

Does this change the corners based on mobile/touch capability or more like
a new default? I would be interested in this as well since our application
is going to be heavy touch screen oriented, huge square blocks for handles
is just ugly.
On Oct 3, 2013 9:27 AM, "cskwg" [email protected] wrote:

Ah, and the rounded corners relate to the grips as well. These usually are
square. I added a function to draw round grips, so that they look nicer on
touch devices.


Reply to this email directly or view it on GitHubhttps://github.com//issues/885#issuecomment-25624480
.

@JRVisualsLLC
Copy link

@cskwg can you share how you accomplished this?

@kangax curious if this should be re-opened now that there's more info.

@kangax kangax reopened this Jun 5, 2015
@kangax kangax changed the title circular corners Circular object controls (corners) Jun 5, 2015
@kangax
Copy link
Member

kangax commented Jun 5, 2015

@JRVisualsLLC sure, I marked it as possible feature. We'll see if we get any more requests for this.

@onassar
Copy link

onassar commented Jan 21, 2016

+1

@asturur
Copy link
Member

asturur commented Apr 13, 2016

i think this should go toghter with customizable controls, is is definitely a subset of it.
(something i would like to start doing)
duplicate of #1947

@asturur asturur closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants