Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: New group object's position changes just before dragging #8562

Closed
7 tasks done
iocoker opened this issue Jan 3, 2023 · 6 comments · Fixed by #8563
Closed
7 tasks done

[Bug]: New group object's position changes just before dragging #8562

iocoker opened this issue Jan 3, 2023 · 6 comments · Fixed by #8563
Assignees

Comments

@iocoker
Copy link
Contributor

iocoker commented Jan 3, 2023

CheckList

  • I agree to follow this project's Code of Conduct
  • I have read and followed the Contributing Guide
  • I have read and followed the Issue Tracker Guide
  • I have searched and referenced existing issues and discussions
  • I am filing a BUG report.
  • I have managed to reproduce the bug after upgrading to the latest version
  • I have created an accurate and minimal reproduction

Version

current master

In What environments are you experiencing the problem?

Chrome

Node Version (if applicable)

None

Link To Reproduction

http://jsfiddle.net/2c3a8w9n/29/

Steps To Reproduce

Mousedown on any of the objects, then drag to reposition. You will observe the item jumps to a large negative left / top and off the screen. You will have to drag down and right to view it again.

JS Fiddle: http://jsfiddle.net/2c3a8w9n/29/

Here's sample video:

Recording.2023-01-03.081809.mp4

Expected Behavior

Maintain its initial position

Actual Behavior

Provided above in steps

Error Message & Stack Trace

This uses the current Fabricjs master 6
ShaMan123 added a commit that referenced this issue Jan 3, 2023
@ShaMan123
Copy link
Contributor

Another great catch!
https://codesandbox.io/s/custom-control-poly-fix-flip-forked-97y0be?file=/src/index.js

@iocoker
Copy link
Contributor Author

iocoker commented Jan 3, 2023

Thank you @ShaMan123 🙏 I think, it affected the scaling of items.

Try resizing any of the shapes or text inside the group:
https://codesandbox.io/s/custom-control-poly-fix-flip-forked-97y0be?file=/src/index.js

Recording.2023-01-03.093719.mp4

@ShaMan123
Copy link
Contributor

I just noticed that I didn't fix it
I am investigating

@ShaMan123
Copy link
Contributor

try now

@iocoker
Copy link
Contributor Author

iocoker commented Jan 3, 2023

Works fine now. Thanks!

@ShaMan123
Copy link
Contributor

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants