Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled "fabric.js" doesn't work on IE10 #5677

Closed
junghwan-park opened this issue May 8, 2019 · 2 comments
Closed

Bundled "fabric.js" doesn't work on IE10 #5677

junghwan-park opened this issue May 8, 2019 · 2 comments

Comments

@junghwan-park
Copy link
Contributor

junghwan-park commented May 8, 2019

Version

2.7.0

Test Case

Test case not needed.

Information about environment

Web Browser / IE10

Steps to reproduce

  1. Execute IE10 browser in Windows OS.
  2. Load web page that loads bundled fabric.js.
  3. Check debugger window console tab.

Expected Behavior

There should be no errors. Script parsed successfully, and ready to use fabric.

Actual Behavior

Browser hasn't HTMLDocument constructor but bundled file header contains HTMLDocument. I can't use fabric in IE10 at all.

@asturur
Copy link
Member

asturur commented May 8, 2019

ie10 should be supported, i'll check the issue.
The problem is that i do not have a ie10 computer anymore. I need to setup a vm.

@junghwan-park
Copy link
Contributor Author

@asturur
As far as I know, HTMLDocument constructor not exists in IE9, IE10. But, It has non HTML5 specification constructor Document. But modern browsers has Document too.

I think HEADER.js#L13's condition statement should be check document is instance of Document constructor when HTMLDocument constructor is undefined.

thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this issue Nov 18, 2019
)

* fix: Check HTMLDocument constructor exists first for IE10 (fixes: fabricjs#5677)

* fix: Remove 'var' definition & use ternary operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants