Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text underline/overline/linethrough should ignore charSpacing at the end of line #5006

Closed
shkaper opened this issue May 30, 2018 · 0 comments
Closed

Text underline/overline/linethrough should ignore charSpacing at the end of line #5006

shkaper opened this issue May 30, 2018 · 0 comments

Comments

@shkaper
Copy link
Contributor

shkaper commented May 30, 2018 •
edited
Loading

Text underline/overline/linethrough should ignore charSpacing at the end of text line. When charSpacing is set to something other than 0 it becomes visible that the decoration line goes over/comes short of text line's end (see Test Case fiddle). A fix would be to just correct ctx.fillRect's width for that amount (see Expected Behavior fiddle, see also PR #5007).

Version

2.3.0

Test Case

http://jsfiddle.net/3hy0h6on/2/

Expected Behavior

http://jsfiddle.net/voe5dmaq/3/ (fabric.Text.prototype._renderTextDecoration overridden)
shkaper added a commit to shkaper/fabric.js that referenced this issue May 30, 2018
@shkaper
fixed text underline/overline/linethrough not ignoring charSpacing at…
97e9f79 
… the end of line (fabricjs#5006)
@shkaper shkaper mentioned this issue May 30, 2018
Merged
asturur pushed a commit that referenced this issue May 30, 2018
@shkaper @asturur
fixed text underline/overline/linethrough not ignoring charSpacing at…
b1c25a4 
… the end of line (#5006) (#5007)
@asturur asturur closed this as completed May 30, 2018
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this issue Nov 18, 2019
@shkaper @asturur
fixed text underline/overline/linethrough not ignoring charSpacing at…
5510149 
… the end of line (fabricjs#5006) (fabricjs#5007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asturur @shkaper