Can't delete text after marking all

[MichaelJDK]

Version

1.7.3

Test Case

https://jsfiddle.net/noeytn5x/

Steps to reproduce

Mark all the text inside the textfield and click the delete key (or any key really)

Expected Behavior

The text is deleted

Actual Behavior

Nothing happens

It however works fine if I mark all by double-clicking

[asturur]

i cannot replicate.
I have no delete button just the backspace since i m on a mac.
Can you replicate with backspace?
Can you replicate building the latest version on github? ( needs building the lib )

[MatBdry]

I have the same issue. You can reproduce it if you try to delete the text in two steps. First select a part of the text, then click on delete key. Then, select the last remaining part, and try to delete it. It does not work.

[asturur]

Delete on PC or MAC?

[MatBdry]

Delete PC. On Mac it works well

[entonbiba]

@asturur @mbaudry yea it lost focus once the delete button is clicked in the text and dragging to the end of the text.

This might be causing the issue

setSelectionStart: function(index) {
      index = Math.max(index, 0);
      this._updateAndFire('selectionStart', index);
    },

setSelectionEnd: function(index) {
      index = Math.min(index, this.text.length);
      this._updateAndFire('selectionEnd', index);
    },

[asturur]

still i cannot understand.
Can we have some more detail on reproduce? i cannot reproduce on windows neither.
OS, browser, key pressed

If we manage to replicate it by code is even better

[entonbiba]

@asturur selecting the full text and pressing delete doesn't remove it.
https://jsfiddle.net/noeytn5x/

This works:

This doesn't:

[MichaelJDK]

For the record, backspace also doesn't delete the text.

[asturur]

i tried on macos vmware with windows 10. i cannot replicate.
Which browser anyway?

[MatBdry]

I have the same problem on ubuntu 10.04 - Chrome 56

[entonbiba]

@asturur it happens on all browsers as long as you select the text using mouse. The only thing that can cause the issue is the selectionEnd. There is also this closed issue with the same problem #1402

setSelectionStart: function(index) {
      index = Math.max(index, 0);
      this._updateAndFire('selectionStart', index);
    },

setSelectionEnd: function(index) {
      index = Math.min(index, this.text.length);
      this._updateAndFire('selectionEnd', index);
    },

[asturur]

at time of issue number 1402 fabric was pretting different. i ll try again to replicate again. i have no luck.

[entonbiba]

@asturur I'll record a gif today

[asturur]

is not about gif, it does not mean i do not trust you.
i need a way to replicate it or i do not know what to fix

[entonbiba]

@asturur ok do the following

1. click at the start of the text with your mouse
   

2. click and drag from the start to the end of the text and a bit outside it, now let go of the mouse click
   

3. press delete or backspace on your keyboard
   Nothing should happen since you have left the textbox input range or the selected text.

[ncou]

Hi,

@entonbiba i can't reproduce it with your steps (PC => win7+chrome 56.0.2924.87).

But if i click at the end of the end of the text (red dot), and select all the text i can reproduce it.

1. double click on the red dot
   2.Don't mouve the mouse, and press the left mouse button and select ALL the text & release your mouse press.
   3.Push DEL or SUPR button and the text is still remaining.

Hope it's help.

[asturur]

when you say press left button you mean mouse or keyboard?

[ncou]

Hum, erratum, in fact it seems like when i select the text and release my selection with the cursor near the border of the jsfiddle, the itext component lose the focus and the delete press button doesn't work.

If i deselect the text in the same iframe all is working fine.

[asturur]

you may have centered the problem. that would be great

[asturur]

i wanted to fix this, i think the only way is hook up the event when you leave the canvas to behave as a mouseup.