Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support radial gradients #36

Closed
kangax opened this issue Jun 30, 2011 · 3 comments
Closed

Support radial gradients #36

kangax opened this issue Jun 30, 2011 · 3 comments
Labels

Comments

@kangax
Copy link
Member

kangax commented Jun 30, 2011

No description provided.

@jafferhaider
Copy link
Contributor

Hey @kangax , was thinking of taking a stab at this. Off the top of my head, here's what needs to be done:

  • Add a type property to the options expected by .setGradientFill() that'd have values linear or radial
  • Use .createRadialGradient() to implement the visuals

Any gotchas in implementing this that I should know of?

@kangax
Copy link
Member Author

kangax commented Feb 5, 2013

Sounds good! Well, createRadialGradient has different syntax (radius 1, radius 2 instead of x1,y1 and x2,y2) so we'll need different parameters to accomodate that.

Aside from that, there's SVG output to take care of, as usual.

@kangax
Copy link
Member Author

kangax commented Mar 9, 2013

Fixed in 5e177b2

@kangax kangax closed this as completed Mar 9, 2013
asturur added a commit that referenced this issue Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants