fix(Polyline): safeguard points arg from options (#9855)

fabricjs · May 6, 2024 · ca171ae · ca171ae
1 parent a504fd9
commit ca171ae
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## [next]
 
+- fix(Polyline): safeguard points arg from options [#9855](https://github.com/fabricjs/fabric.js/pull/9855)
 - feat(IText): Adjust cursor blinking for better feedback [#9823](https://github.com/fabricjs/fabric.js/pull/9823)
 - feat(FabricObject): pass `e` to `shouldStartDragging` [#9843](https://github.com/fabricjs/fabric.js/pull/9843)
 - fix(Canvas): mouse move before event data [#9849](https://github.com/fabricjs/fabric.js/pull/9849)

diff --git a/src/shapes/Polyline.spec.ts b/src/shapes/Polyline.spec.ts
@@ -106,4 +106,12 @@ describe('Polyline', () => {
       });
     });
   });
+
+  it('should safeguard passing points in options', () => {
+    expect(new Polyline(points, { points: [{ x: 1, y: 1 }] })).toEqual(
+      expect.objectContaining({
+        points: points,
+      })
+    );
+  });
 });
diff --git a/src/shapes/Polyline.ts b/src/shapes/Polyline.ts
@@ -108,7 +108,7 @@ export class Polyline<
    * });
    */
   constructor(points: XY[] = [], options: Props = {} as Props) {
-    super({ points, ...options });
+    super({ ...options, points });
     const { left, top } = options;
     this.initialized = true;
     this.setBoundingBox(true);