Merge pull request #2344 from asturur/emptypath

Allow to create path with empty path
fabricjs · Jul 15, 2015 · 61d4f4d · 61d4f4d
2 parents 0e154be + d36945f
commit 61d4f4d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/shapes/path.class.js b/src/shapes/path.class.js
@@ -78,7 +78,7 @@
       this.setOptions(options);
 
       if (!path) {
-        throw new Error('`path` argument is required');
+        path = [ ];
       }
 
       var fromArray = _toString.call(path) === '[object Array]';
@@ -888,10 +888,10 @@
         aY.push(y);
       }
 
-      var minX = min(aX),
-          minY = min(aY),
-          maxX = max(aX),
-          maxY = max(aY),
+      var minX = min(aX) || 0,
+          minY = min(aY) || 0,
+          maxX = max(aX) || 0,
+          maxY = max(aY) || 0,
           deltaX = maxX - minX,
           deltaY = maxY - minY,
 

diff --git a/test/unit/path.js b/test/unit/path.js
@@ -70,7 +70,7 @@
         error = err;
       }
 
-      ok(error, 'should throw error');
+      ok(typeof error === 'undefined', 'should not throw error on empty path');
       start();
     });
   });