fix(controls): Control offsets extra rendering issue (#6114)

fabricjs · Jan 22, 2020 · 5af4b68 · 5af4b68
1 parent 2af77f9
commit 5af4b68
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [4.0.0-beta.3]
+
+fix: control offset rendering code had extras `beginPath` that would clear all but not the last of them [#6114](https://github.com/fabricjs/fabric.js/pull/6114)
+
 ## [4.0.0-beta.2]
 
 fix: Control.getVisibility will always receive the fabric.Object argument.

diff --git a/HEADER.js b/HEADER.js
@@ -1,6 +1,6 @@
 /*! Fabric.js Copyright 2008-2015, Printio (Juriy Zaytsev, Maxim Chernyak) */
 
-var fabric = fabric || { version: '4.0.0-beta.2' };
+var fabric = fabric || { version: '4.0.0-beta.3' };
 if (typeof exports !== 'undefined') {
   exports.fabric = fabric;
 }

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "fabric",
   "description": "Object model for HTML5 canvas, and SVG-to-canvas parser. Backed by jsdom and node-canvas.",
   "homepage": "http://fabricjs.com/",
-  "version": "4.0.0-beta.2",
+  "version": "4.0.0-beta.3",
   "author": "Juriy Zaytsev <[email protected]>",
   "contributors": [
     {

diff --git a/src/mixins/object_interactivity.mixin.js b/src/mixins/object_interactivity.mixin.js
@@ -189,10 +189,10 @@
       );
 
       if (hasControls) {
+        ctx.beginPath();
         this.forEachControl(function(control, key, fabricObject) {
           // in this moment, the ctx is centered on the object.
           // width and height of the above function are the size of the bbox.
-          ctx.beginPath();
           if (control.withConnection && control.getVisibility(fabricObject)) {
             // reset movement for each control
             shouldStroke = true;