Skip to content

Commit

Permalink
ci(): Add Node 22 in the test runs (#10310)
Browse files Browse the repository at this point in the history
  • Loading branch information
asturur authored Dec 3, 2024
1 parent 68e0fa1 commit 1f62cde
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 22 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Uglified build
uses: actions/checkout@v4
Expand All @@ -17,7 +17,7 @@ jobs:
- run: npm run build
stats:
name: Build stats
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
env:
minified: dist/index.min.js
bundled: dist/index.mjs
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
b: JSON.parse('${{ steps.b.outputs.result }}'),
});
lint:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Linting
uses: actions/checkout@v4
Expand All @@ -78,7 +78,7 @@ jobs:
node-version: 20.x
- run: npm run lint
prettier:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Prettier check
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:

jobs:
changelog:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
env:
file: CHANGELOG.md
steps:
Expand All @@ -30,7 +30,7 @@ jobs:
exit 1
fi
update:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: changelog
if: (inputs.create && failure()) || (inputs.update && success())
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
actions: read
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npmpublish-next.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
publish-npm:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/npmpublish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
publish-npm:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -23,7 +23,7 @@ jobs:
NODE_AUTH_TOKEN: ${{secrets.npm_token}}
PRE_RELEASE: ${{github.event.release.prerelease}}
update-bug-report:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
# wait for publishing to complete
needs: publish-npm
if: always()
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
prime-build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Install dependencies
Expand All @@ -21,7 +21,7 @@ jobs:
uses: ./.github/actions/build-fabric-cached
node-coverage:
needs: [prime-build]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
name: Node 20.x ${{ matrix.suite }} tests
strategy:
fail-fast: false
Expand Down Expand Up @@ -53,10 +53,10 @@ jobs:
browser:
needs: [prime-build]
name: ${{ matrix.target }} ${{ matrix.suite }} tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
strategy:
matrix:
node-version: [20.x]
node-version: [20]
target: [chrome, firefox]
suite: [unit, visual]
fail-fast: false
Expand All @@ -72,29 +72,29 @@ jobs:
run: xvfb-run npm run test -- -c ${{ matrix.target }} -s ${{ matrix.suite }}
node:
needs: [prime-build]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
name: Node ${{ matrix.node-version }} ${{ matrix.suite }} tests
strategy:
fail-fast: false
matrix:
# For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
# supported Node.js release schedule: https://nodejs.org/en/about/releases/
node-version: ['18.x']
node-version: [18, 22]
suite: [unit, visual]
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cached-install
with:
node-version: ${{ matrix.node-version }}
install-system-deps: 'false'
install-system-deps: ${{ matrix.node-version >= 22 }}
- name: Build fabric.js
uses: ./.github/actions/build-fabric-cached
- name: Run ${{ matrix.suite }} tests
run: npm run test -- -c node -s ${{ matrix.suite }}
jest:
name: Jest tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cached-install
Expand All @@ -112,7 +112,7 @@ jobs:
e2e:
needs: [prime-build]
name: Playwright tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cached-install
Expand All @@ -139,12 +139,12 @@ jobs:
coverage:
needs: [node-coverage, e2e]
name: Coverage reporting
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/cached-install
with:
node-version: 20.x
node-version: 18.x
install-system-deps: false
- uses: actions/download-artifact@v4
with:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [next]

- ci(): Test node 22 again [#10310](https://github.com/fabricjs/fabric.js/pull/10310)
- chore(TS): Try to remove all TS-ERROR directives [#10309](https://github.com/fabricjs/fabric.js/pull/10309)
- chore(): Make TS config more strict [#10308](https://github.com/fabricjs/fabric.js/pull/10308)
- fix(Color): Support uppercase keywords [#10300](https://github.com/fabricjs/fabric.js/pull/10300)
Expand Down
2 changes: 1 addition & 1 deletion test/visual/text.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@
width: 480,
height: 190,
golden: 'text9.png',
percentage: 0.09,
percentage: 0.10,
});

function text10(canvas, callback) {
Expand Down

0 comments on commit 1f62cde

Please sign in to comment.