Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested tests where only the last nested test was printed #26 #40

Merged
merged 2 commits into from
May 13, 2023

Conversation

blutorange
Copy link
Contributor

Fixes #26, the new reports simply had to be added to the existing reports

@fabriciorby fabriciorby self-requested a review May 13, 2023 19:03
@fabriciorby
Copy link
Owner

Hey @blutorange, thanks for your PR.

I just ran it against this test scenario and it still miss some Nested tests, can you try as well?

@blutorange
Copy link
Contributor Author

blutorange commented May 13, 2023

No problem, it's my pleasure. Regarding the nested tests, are you certain you've been using the right version? I tried it like this:

git remote add https://github.com/blutorange/maven-surefire-junit5-tree-reporter
git fetch blutorange
git checkout blutorange/fix-nested-tests
 # edit pom.xml, set version to something like 1.1.0+FixNestedTests
mvn clean install -Dmaven.javadoc.skip -Dgpg.skip
cd ..
git clone https://github.com/rkraneis/tree-reporter
cd tree-reporter
git checkout 2a656ebb9e4c5c39371b5fd4e849c326641437fb
# edit pom.xml, set version to 1.1.0+FixNestedTests
mvn test

This gives me the following output

image

Which should be all test cases (although in a different order)

@fabriciorby
Copy link
Owner

No problem, it's my pleasure. Regarding the nested tests, are you certain you've been using the right version? I tried it like this:

git remote add https://github.com/blutorange/maven-surefire-junit5-tree-reporter
git fetch blutorange
git checkout blutorange/fix-nested-tests
 # edit pom.xml, set version to something like 1.1.0+FixNestedTests
mvn clean install -Dmaven.javadoc.skip -Dgpg.skip
cd ..
git clone https://github.com/rkraneis/tree-reporter
cd tree-reporter
git checkout 2a656ebb9e4c5c39371b5fd4e849c326641437fb
# edit pom.xml, set version to 1.1.0+FixNestedTests
mvn test

This gives me the following output

image

Which should be all test cases (although in a different order)

Thanks for trying, it was my bad! I got the wrong version :P

Thanks for fixing this issue!

@fabriciorby fabriciorby merged commit 34f8af5 into fabriciorby:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Some) nested tests are not printed at all
3 participants