-
Notifications
You must be signed in to change notification settings - Fork 72
Conversation
@jimmidyson: Can you please have a look? |
@iocanel It would be great even if you can review it :) |
@iocanel @jimmidyson could you please review it ASAP? |
cmd/generate/generate.go
Outdated
@@ -88,7 +88,9 @@ type Schema struct { | |||
ImageList imageapi.ImageList | |||
ImageStreamList imageapi.ImageStreamList | |||
ImageStreamTagList imageapi.ImageStreamTagList | |||
DeploymentConfig deployapi.DeploymentConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs go fmt
ing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
cmd/generate/generate.go
Outdated
DeploymentConfigList deployapi.DeploymentConfigList | ||
Route routeapi.Route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -12600,6 +12600,10 @@ | |||
"$ref": "#/definitions/kubernetes_extensions_Deployment", | |||
"javaType": "io.fabric8.kubernetes.api.model.extensions.Deployment" | |||
}, | |||
"DeploymentConfig": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these lost in a previous generation? These have always been there before, no idea how they're newly added now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact me I was surprised for this
The updated schema in this PR doesn't contain any resources elements, which I thought was the point of this PR? I'm a bit confused tbh. Plus my comment on the relevant issue about whether this is breaking a valid JSON schema document to add a custom element ( |
369b418
to
8293856
Compare
@jimmidyson added updated JSON schema. It may not be valid as per the JSON schema specification, but I have tested this change with kubernetes-client, f8-m-p project and its not breaking anything yet. |
I'm still not clear what this does for you to help with validation. Why is the JSON schema not good enough in its current form? |
Hey @jimmidyson
In f8-m-p we have enabled resource/spec/template validation with JSON schema. Please read fabric8io/fabric8-maven-plugin#1051 (comment) first point. |
8293856
to
6c8f134
Compare
6c8f134
to
772aaef
Compare
@jimmidyson @jstrachan |
LGTM |
@jimmidyson @jstrachan @iocanel how to trigger the build again. Just wondering build is getting failed on this environment but getting passed on my dev. environment. Any suggestions? |
retest this please |
I added some JVM flags last week that were recommended which may be affecting this. Lemme remove and kick off another build to see if that helps. |
@rawlingsj thanks a ton! |
- added resources property to schema for validation
e6bd1de
to
b9d12ef
Compare
JSON schema change for #229