-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This will fix the issue of securityContextConstraints are not getting created #982
Conversation
ok to test |
@iocanel WDYT about this? |
Since fabric8io/kubernetes-model#273 has been closed, I believe this one too must be closed. |
@oscerd That issue is closed because of different reason. I am trying to fix this issue in the model. If that works, then we will close this, otherwise, this can be the solution for the problem. That PR is closed right now, because of the wrong approach. Thanks |
Sorry about that, I supposed it was related :-) By the way the fix is ok, lets wait for others reviews |
Added about how to change ApiVersion while creating resource in readme Added license
@oscerd can you please comment retest and also review this PR now. |
Retest this please |
Maybe add an entry to the changelog forma this fix. We need to track changes better. |
Not sure why, but 3.6.1 job didn't restart. Maybe we can close and reopen the PR |
ok to test |
Let's keep this PR on hold, I am currently working on #969 . As we already added the support for PodSecurityPolicy in Model. I think after resolving #969, if everything works fine, we can do a release of the model project and subsequent model version changes in client and this will only get fixed after using the latest model. WDYT? Thanks |
Yeah, lets do in this way. I forgot that we aren't using snapshot of kube-model here. |
retest this please |
Added an example of Security Context Constraints
Updated the docs regarding how to change apiVersion.
#962