Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This will fix the issue of securityContextConstraints are not getting created #982

Merged
merged 2 commits into from
Jan 24, 2018

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jan 11, 2018

Added an example of Security Context Constraints

Updated the docs regarding how to change apiVersion.

#962

@oscerd
Copy link
Member

oscerd commented Jan 17, 2018

ok to test

@oscerd
Copy link
Member

oscerd commented Jan 17, 2018

@iocanel WDYT about this?

@oscerd
Copy link
Member

oscerd commented Jan 17, 2018

Since fabric8io/kubernetes-model#273 has been closed, I believe this one too must be closed.

@oscerd oscerd closed this Jan 17, 2018
@piyush-garg piyush-garg reopened this Jan 17, 2018
@piyush-garg
Copy link
Contributor Author

@oscerd That issue is closed because of different reason. I am trying to fix this issue in the model. If that works, then we will close this, otherwise, this can be the solution for the problem.

That PR is closed right now, because of the wrong approach.

Thanks

@oscerd
Copy link
Member

oscerd commented Jan 17, 2018

Sorry about that, I supposed it was related :-)

By the way the fix is ok, lets wait for others reviews

Added about how to change ApiVersion while creating resource in readme

Added license
@piyush-garg
Copy link
Contributor Author

@oscerd #274 will ix ths issue for SecurityContextConstraints

This PR is now adding an example of SCC and handling document changes only.

Thanks

@piyush-garg
Copy link
Contributor Author

@oscerd can you please comment retest and also review this PR now.

@oscerd
Copy link
Member

oscerd commented Jan 18, 2018

Retest this please

@oscerd
Copy link
Member

oscerd commented Jan 18, 2018

Maybe add an entry to the changelog forma this fix. We need to track changes better.

@oscerd
Copy link
Member

oscerd commented Jan 19, 2018

Not sure why, but 3.6.1 job didn't restart. Maybe we can close and reopen the PR

@oscerd
Copy link
Member

oscerd commented Jan 19, 2018

ok to test

@piyush-garg
Copy link
Contributor Author

@oscerd

Let's keep this PR on hold, I am currently working on #969 .

As we already added the support for PodSecurityPolicy in Model. I think after resolving #969, if everything works fine, we can do a release of the model project and subsequent model version changes in client and this will only get fixed after using the latest model.

WDYT?

Thanks

@oscerd
Copy link
Member

oscerd commented Jan 19, 2018

Yeah, lets do in this way. I forgot that we aren't using snapshot of kube-model here.

@oscerd
Copy link
Member

oscerd commented Jan 23, 2018

retest this please

@hrishin hrishin merged commit 6a1d162 into fabric8io:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants