Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crd-generator): Fix processing private and package-private CustomResource classes #6686

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

baloo42
Copy link
Contributor

@baloo42 baloo42 commented Dec 1, 2024

Description

Fixes #6685

Aligns the capabilities of the CRDGenerator collector with the api-v2, so that all found CustomResource classes can be processed. This solution makes the default constructor of a CustomResource class accessible if it is required.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@baloo42 baloo42 changed the title CRDGenerator: Fix processing private and package-private CustomResource classes fix(crd-generator): Fix processing private and package-private CustomResource classes Dec 1, 2024
@baloo42 baloo42 marked this pull request as ready for review December 1, 2024 12:07
@manusa manusa added this to the 7.0.0 milestone Dec 2, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit fa7d5d5 into fabric8io:main Dec 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRDGenerator: Private CustomResource classes are found while scanning but cannot be processed
3 participants