fix(model): Use SettableBeanProperty.Delegating for jackson delegation #6343
Conversation
fxshlein
requested review from
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
|
Ironically, |
| SettableBeanProperty secondDelegateMock = mock(SettableBeanProperty.class, RETURNS_DEEP_STUBS); | ||
| doReturn(secondDelegateMock).when(delegateMock).withValueDeserializer(any()); |
There was a problem hiding this comment.
Jackson is being smart here, and they have a check whether the new delegate is the same as the old, so a separate one needs to be used to test this.
There was a problem hiding this comment.
I left these tests here for now, since I think they are still useful for verifying that the jackson delegation works as expected. For example, without these, I would not have noticed that isIgnorable and markAsIgnorable are not delegated by jackson.
Changes the delegation in SettableBeanPropertyDelegate from a custom implementation to the standard way of implementing a delegating property in jackson. This way, if some jackson module overrides methods that are not delegated explicitely here, they will continue to work. Fixes: fabric8io#6342
…nce instead of null Signed-off-by: Marc Nuri <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
…eBeanProperty Includes tests to ensure all methods are implemented in future Jackson versions too. Signed-off-by: Marc Nuri <[email protected]>
|
Description
Fixes: #6342
Changes the delegation in
SettableBeanPropertyDelegatefrom a custom implementation to the standard way of implementing a delegating property in jackson. This way, if some jackson module overrides methods that are not delegated explicitely here, they will continue to work.Type of change
test, version modification, documentation, etc.)
Checklist