Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: openshift-model & openshift-mode-miscellaneous generated from OpenAPI schemas #6336

Merged
merged 1 commit into from
Sep 17, 2024
Merged

refactor: openshift-model & openshift-mode-miscellaneous generated from OpenAPI schemas #6336

merged 1 commit into from
Sep 17, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Sep 6, 2024 •
edited
Loading

Description

Fixes #6259
Fixes #6268

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa force-pushed the refactor/openapi-openshift-model branch 3 times, most recently from e722a50 to 2509f03 Compare September 11, 2024 09:37
@manusa manusa force-pushed the refactor/openapi-openshift-model branch 8 times, most recently from 36c24aa to aadf63d Compare September 17, 2024 13:17
@manusa manusa force-pushed the refactor/openapi-openshift-model branch from aadf63d to c2e8068 Compare September 17, 2024 13:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@manusa manusa added this to the 7.0.0 milestone Sep 17, 2024 — with automated-tasks
@manusa manusa marked this pull request as ready for review September 17, 2024 16:13
@manusa manusa merged commit 5a7e031 into fabric8io:main Sep 17, 2024
20 of 21 checks passed
@manusa manusa deleted the refactor/openapi-openshift-model branch September 17, 2024 16:14
This was referenced Sep 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
2 participants
@manusa @oscerd