Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inlined schemas are compatible with sundrio builder generator #6325

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Sep 3, 2024

Description

Fixes #6320

Generated inline OpenAPI schemas don't use class/component names that might collide with sundrio-generated builder methods such as withSpec, withStatus, and so on.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 7.0.0 milestone Sep 3, 2024 — with automated-tasks
@manusa manusa force-pushed the fix/sundrio-inline-openapi branch from 2e0cd81 to 201f9f4 Compare September 3, 2024 12:26
Copy link

sonarqubecloud bot commented Sep 3, 2024

@manusa manusa merged commit fa66bf0 into fabric8io:main Sep 3, 2024
21 checks passed
@manusa manusa deleted the fix/sundrio-inline-openapi branch September 3, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sundrio builder generation for types having KubernetesResource fields
3 participants