chore : Migrate to OSGi Service Component annotations to ManagedKubernetesClient / ManagedOpenShiftClient #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Aug 22, 2024
rohanKanojia
force-pushed
the
pr/issue4445
branch
from
b4d2c75 to
8b3b8ce
Compare
rohanKanojia
commented
Aug 22, 2024
| @@ -43,6 +43,7 @@ public class FeatureInstallationTest extends TestBase { | |||
| @Test | |||
| public void testKubernetesClientFeature() throws Exception { | |||
| featuresService.addRepository(getFeaturesFile().toURI()); | |||
| featuresService.installFeature("scr"); | |||
There was a problem hiding this comment.
After migrating to OSGi Component annotations from Felix SCR annotations, I see this additional text added in the MANIFEST.MF Require-Capability by maven bundle plugin
filter:="(&(osgi.extender=osgi.compo
nent)(version>=1.5.0)(!(version>=2.0.0)))
This causes karaf tests to fail with missing requirement. Once I install scr feature test passes.
There was a problem hiding this comment.
I moved it as a dependency feature in feature.xml
rohanKanojia
force-pushed
the
pr/issue4445
branch
from
8b3b8ce to
1620dfd
Compare
rohanKanojia
force-pushed
the
pr/issue4445
branch
2 times, most recently
from
b32c9f4 to
28b38e6
Compare
…lient + Remove Apache Felix SCR annotations as they're unsupported. + Add OSGi Service Component annotations to ManagedKubernetesClient and ManagedOpenShiftClient Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue4445
branch
from
28b38e6 to
10e2e9e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4445
Apache Felix SCR annotations are not supported anymore. Please see:
org.apache.felix:maven-scr-pluginfrom modules that were using Felix SCR annotationsType of change
test, version modification, documentation, etc.)
Checklist