Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: kubernetes-model-policy generated from OpenAPI schemas #6234

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Aug 8, 2024

Description

Fixes #6185

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 7.0.0 milestone Aug 8, 2024 — with automated-tasks
@Generated("jsonschema2pojo")
public class Eviction implements Editable<EvictionBuilder> , HasMetadata, Namespaced
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are interfaces removed?

@rohanKanojia
Copy link
Member

Build seems to be failing:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project kubernetes-client: Compilation failure
Error:  /home/runner/work/kubernetes-client/kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/PodOperationsImpl.java:[244,24] incompatible types: io.fabric8.kubernetes.api.model.policy.v1beta1.Eviction cannot be converted to io.fabric8.kubernetes.api.model.HasMetadata

Not sure why v1beta1 Eviction can no longer be casted to HasMetadata

@manusa manusa force-pushed the refactor/openapi-policy branch from 40bdb75 to d218090 Compare August 8, 2024 15:05
@manusa
Copy link
Member Author

manusa commented Aug 8, 2024

Build seems to be failing:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project kubernetes-client: Compilation failure
Error:  /home/runner/work/kubernetes-client/kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/PodOperationsImpl.java:[244,24] incompatible types: io.fabric8.kubernetes.api.model.policy.v1beta1.Eviction cannot be converted to io.fabric8.kubernetes.api.model.HasMetadata

Not sure why v1beta1 Eviction can no longer be casted to HasMetadata

#6234 (comment)

Should be fixed now, had to fine-tune the process to merge OpenAPI schemas.

Copy link

sonarqubecloud bot commented Aug 8, 2024

@manusa manusa merged commit 73f8f4a into fabric8io:main Aug 9, 2024
21 checks passed
@manusa manusa deleted the refactor/openapi-policy branch August 9, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Go model generation for kubernetes-model-policy
3 participants