fix(client): improve reliability of file upload to pod (#6212) #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhussonnois
requested review from
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
|
@fhussonnois can you update the unit test expectations as well? There are several that check for the full command string being created. |
fhussonnois
force-pushed
the
fix/gh-6212
branch
from
91aa66c to
ec7fddb
Compare
|
Tests should be OK now! |
Fix: fabric8io#6212 Signed-off-by: Florian Hussonnois <[email protected]>
fhussonnois
force-pushed
the
fix/gh-6212
branch
from
ec7fddb to
c9e22e7
Compare
|
shawkins
approved these changes
Aug 5, 2024
18 tasks
rohanKanojia
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #6212
Type of change
test, version modification, documentation, etc.)
Checklist