Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't add apiVersion,kind,metadata fields indiscriminately to JsonPropertyOrder #6092

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 1, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa self-assigned this Jul 1, 2024
@manusa manusa modified the milestones: 6.13.1, 7.0.0 Jul 1, 2024
@manusa manusa force-pushed the fix/serialization-properties branch from ebf244b to 414d0fb Compare July 1, 2024 11:21
@manusa
Copy link
Member Author

manusa commented Jul 1, 2024

Relevant changes in first commit:

d00baea

Copy link

sonarqubecloud bot commented Jul 1, 2024

@manusa manusa merged commit 5136bb0 into fabric8io:main Jul 1, 2024
21 checks passed
@manusa manusa deleted the fix/serialization-properties branch July 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant