Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump org.projectlombok:lombok from 1.18.32 to 1.18.34 #6090

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 28, 2024

Bumps org.projectlombok:lombok from 1.18.32 to 1.18.34.

Changelog

Sourced from org.projectlombok:lombok's changelog.

v1.18.34 (June 28th, 2024)

  • PLATFORM: Added support for Eclipse 2024-06; you'd get some NoSuchMethodError traces in your logs if using @Builder or @Singular prior to this fix. [Issue #3638](projectlombok/lombok#3638).
  • IMPROBABLE BREAKING CHANGE: Lombok now adds @lombok.Generated by default to methods and types it generates. This may result in accidentally increasing your test coverage percentage. [Issue #3667](projectlombok/lombok#3667).
  • IMPROBABLE BREAKING CHANGE: When lombok.config contains lombok.onX.flagUsage = WARNING, from now on warnings will actually be generated if onX is used.[Issue #2848](projectlombok/lombok#2848)
  • BUGFIX: When @SuperBuilder was used on a type with an generic array type, it would error wrong number of type arguments. [Issue #3694](projectlombok/lombok#3694).
  • FEATURE: Lombok generates javadoc for you for most of the methods it adds; with this release, javadoc is also added to generated constructors. [Issue #933](projectlombok/lombok#933).
Commits
  • fbbe7f0 [release] pre-release version bump
  • 3cd41e8 [trivial] some test cases were failing (due to the constructor-javadoc update...
  • 1384244 Merge pull request #3698 from stevebosman/fix-sneaky-throws-doc
  • d90ec73 [trivial] [style]
  • 3b68e39 Merge pull request #3697 from janrieke/superbuilder-fix-array-type-param
  • fdafa9a Merge pull request #3690 from Rawi01/eclipse_2024_06
  • 78c1f47 Merge pull request #3689 from Rawi01/nested-javadoc
  • da815a6 Merge pull request #3674 from Rawi01/standardexception-fields
  • c61a404 [trivial]
  • 6cf6caf Merge pull request #3673 from Rawi01/eclipse_field_generated
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 28, 2024
@rohanKanojia
Copy link
Member

Build is failing :

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project openshift-client-api: Compilation failure
Error:  cannot access lombok.Generated
Error:    class file for lombok.Generated not found
Error:    Consult the following stack trace for details.
Error:    com.sun.tools.javac.code.Symbol$CompletionFailure: class file for lombok.Generated not found
Error:  -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project openshift-client-api: Compilation failure
cannot access lombok.Generated
  class file for lombok.Generated not found
  Consult the following stack trace for details.
  com.sun.tools.javac.code.Symbol$CompletionFailure: class file for lombok.Generated not found

@rohanKanojia
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.projectlombok-lombok-1.18.34 branch from b299b6c to 523f491 Compare July 12, 2024 13:27
@rohanKanojia
Copy link
Member

I see this issue happening only on JDK8. On JDK11and JDK17 I'm not able to reproduce this issue.

@manusa
Copy link
Member

manusa commented Jul 15, 2024

I see this issue happening only on JDK8. On JDK11and JDK17 I'm not able to reproduce this issue.

That's weird. What initially was some side effect of:

IMPROBABLE BREAKING CHANGE: Lombok now adds @lombok.Generated by default to methods and types it generates. This may result in accidentally increasing your test coverage percentage. [Issue #3667](projectlombok/lombok#3667).

@rohanKanojia
Copy link
Member

Providing lombok.addLombokGeneratedAnnotation = false in lombok.conig seems to fix the issue. However, I'm not sure we want to opt out of this functionality.

dependabot bot and others added 2 commits July 15, 2024 13:54
Bumps [org.projectlombok:lombok](https://github.com/projectlombok/lombok) from 1.18.32 to 1.18.34.
- [Changelog](https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown)
- [Commits](projectlombok/lombok@v1.18.32...v1.18.34)

---
updated-dependencies:
- dependency-name: org.projectlombok:lombok
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@rohanKanojia rohanKanojia force-pushed the dependabot/maven/org.projectlombok-lombok-1.18.34 branch from 523f491 to 4f0569e Compare July 15, 2024 08:24
Copy link

@manusa manusa added this to the 7.0.0 milestone Jul 15, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit b7a078a into main Jul 15, 2024
21 checks passed
@manusa manusa deleted the dependabot/maven/org.projectlombok-lombok-1.18.34 branch July 15, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants