test(crd-generator-v2): ensure Collection properties work like List in CRD generation #6018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RD generation - Updated `ServiceSpec` to use `Collection` instead of `List` for `loadBalancerSourceRanges`. - Modified getter and setter methods for `loadBalancerSourceRanges` to use `Collection`. - Confirmed that CRD generation produces a field of type array when using `Collection`, ensuring compatibility and correct schema output. Signed-off-by: Sun Seng David TAN <[email protected]>
sunix
requested review from
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
oscerd
approved these changes
May 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making sure #5417 could not be reproduced with crd-generator-v2
In the tests
ServiceSpecto useCollectioninstead ofListforloadBalancerSourceRanges.loadBalancerSourceRangesto useCollection.Collection, ensuring compatibility and correct schema output.Type of change
test, version modification, documentation, etc.)
Checklist