-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crd-generator): Add CRD-Generator Maven plugin #5979
Merged
+5,496
−5
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f6040bd
feat(crd-generator): Add CRD-Generator Maven plugin
baloo42 4057f67
Add crd-generator-collector module
baloo42 d4b7f2a
Refactor crd-generator-maven-plugin to use collector module
baloo42 1dce59e
Adjusted log levels and allow to force create indices
baloo42 dbc1153
Enable parallel by default in crd-generator maven plugin
baloo42 f4a6028
Remove not necessary classes from base index
baloo42 d7be6a6
Cleanup
baloo42 ff1b97d
More cleanup
baloo42 a283857
Fix base index (must also include CustomResource)
baloo42 9ab5fac
Fix includes/excludes and some code smells
baloo42 9125a0a
Add CustomResourceCollector tests
baloo42 85fcc91
Cleanup, add tests and fix code smells
baloo42 f91de1c
Add tests for crd-generator-maven-plugin and fix code smells
baloo42 ef4fe25
Fix code smells
baloo42 9ed611c
Remove high level filtering and return an array of cr classes instead…
baloo42 b536658
Refactor Jandex utility methods to be more reusable
baloo42 b0eef86
Polish var names, add javadoc, improve error handling, refactor tests
baloo42 c47fe6d
Fix CrdGeneratorMojoTest
baloo42 c7d2ab9
Fix code smells
baloo42 9e85e4b
Try to fix tests
baloo42 e227f15
Use same jandex version for core module and maven plugin
baloo42 cc18c80
Add README for crd-generator maven plugin
baloo42 e1c768b
Fix README
baloo42 e8c881f
Add integration tests using maven-invoker plugin
baloo42 818d37f
Add more integration tests and verify content
baloo42 db4c6a2
Add integration tests for intermediate custom resource classes
baloo42 0fc55ed
Remove CrdGeneratorMojoTest - already covered by integration test
baloo42 fe68d5d
Fix ClasspathTypeTest
baloo42 0c6a349
Fix groovy files formatting
baloo42 25d34f0
Fix version after rebase
baloo42 b5ebcac
Reimplement integration tests to be OS independent
baloo42 82677b9
Add collection input methods to CRDGenerator
baloo42 f5dac69
Refactor CustomResourceCollector to use only a list as output
baloo42 9551136
Fix integration tests for Java 8
baloo42 bcf601d
Make file comparison in integration tests OS independent
baloo42 b1ce3de
Add groovy formatter settings to parent pom and remove crd-generator …
baloo42 02976f1
Make reset methods package-private
baloo42 f10f525
Add @SuppressWarnings("UnusedReturnValue") to get rid of all warnings
baloo42 b9a8534
Improve log message
baloo42 04228c9
Fix jandex version after rebase
baloo42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add @SuppressWarnings("UnusedReturnValue") to get rid of all warnings
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need limits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem reasonable limits.
We can keep it this way.
If users complain, then we can make this configurable in a future release (at the Mojo level).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's keep it.
Just as a note:
I'm a little bit unsure if those checks make sense overall...
I mean, if a project cannot trust it's dependencies, then the project has more problems than those from a zip bomb. But if we think towards the CRD-Generator CLI, it's some kind of own input validation and kind of useful.