-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to include dependencies #5918
Conversation
@andreaTP How's this look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong or outdated, but:
kubernetes-model
is already a transitive dependency of the clientopenshift-client
is not needed, we can, rely only on thekubernetes-client
(or a more fine grained dependency)
And thanks a lot for taking the time to put this together! |
e3e167f
to
81cf993
Compare
81cf993
to
ca2ac8d
Compare
You're not wrong. |
@matteriben : Could you please resolve these minor conflicts and push again? Somehow CI checks seem stuck. |
ca2ac8d
to
c69a102
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Type of change
test, version modification, documentation, etc.)
Checklist