Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to include dependencies #5918

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

matteriben
Copy link
Contributor

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@matteriben
Copy link
Contributor Author

@andreaTP How's this look?

Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong or outdated, but:

  • kubernetes-model is already a transitive dependency of the client
  • openshift-client is not needed, we can, rely only on the kubernetes-client (or a more fine grained dependency)

doc/java-generation-from-CRD.md Outdated Show resolved Hide resolved
@andreaTP
Copy link
Member

And thanks a lot for taking the time to put this together!

@matteriben matteriben marked this pull request as draft April 19, 2024 15:09
@matteriben matteriben force-pushed the iss_5878_documentation branch from e3e167f to 81cf993 Compare April 19, 2024 15:17
@matteriben matteriben marked this pull request as ready for review April 19, 2024 15:17
@matteriben matteriben force-pushed the iss_5878_documentation branch from 81cf993 to ca2ac8d Compare April 19, 2024 15:45
@matteriben
Copy link
Contributor Author

I might be wrong or outdated, but:

  • kubernetes-model is already a transitive dependency of the client
  • openshift-client is not needed, we can, rely only on the kubernetes-client (or a more fine grained dependency)

You're not wrong.

@rohanKanojia
Copy link
Member

@matteriben : Could you please resolve these minor conflicts and push again? Somehow CI checks seem stuck.

@matteriben matteriben force-pushed the iss_5878_documentation branch from ca2ac8d to c69a102 Compare April 22, 2024 15:38
@matteriben matteriben requested a review from andreaTP April 22, 2024 19:26
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@manusa manusa added this to the 6.13.0 milestone Apr 23, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 492264e into fabric8io:main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants