Drain HttpResponse in tests
#5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In Armeria CI, we saw Netty leak reports from kubernetes-client CI tests. After investigating, I found out that some of the tests did not consume `HttpResponse`. As a result, some `ByteBuf`s were not subscribed to and remained in the Publisher's internal buffer. Modifications: - Fixed to call `AsyncBody.consume()` where it was not called before. Result: No more leaks in CI builds.
ikhoon
requested review from
manusa,
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
rohanKanojia
approved these changes
Apr 2, 2024
|
@ikhoon : Could you please run |
oscerd
approved these changes
Apr 2, 2024
I've done. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Armeria CI, we saw Netty leak reports from kubernetes-client CI tests. After investigating, I found out that some of the tests did not consume
HttpResponse. As a result,ByteBufs were not subscribed to and remained in the Publisher's internal buffer.I fixed to call
AsyncBody.consume()in tests where it was not called before.Type of change
test, version modification, documentation, etc.)
Checklist