Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test for expectSentWebSocketMessage to match specification #5714

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Jan 18, 2024

Description

Fix #5713

  • Modifies the description to make it accurate
  • Removes unneeded and misleading test implementation section

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

- Modifies the description to make it accurate
- Removes unneeded and misleading test implementation section
@manusa manusa added this to the 6.11.0 milestone Jan 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@manusa manusa merged commit ce3a21d into fabric8io:main Jan 18, 2024
17 of 19 checks passed
@manusa manusa deleted the test/expect-sent-web-socket-message branch January 18, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockWebServer expectSentWebSocketMessage
3 participants