fix: adding PodResource.patchReadinessGateStatus #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawkins
requested review from
manusa,
oscerd,
rohanKanojia and
sunix
as code owners
oscerd
approved these changes
Jan 8, 2024
csviri
approved these changes
Jan 8, 2024
manusa
approved these changes
Jan 8, 2024
also adding a general subresource method closes fabric8io#5496
rohanKanojia
reviewed
Jan 8, 2024
| /** | ||
| * Provides edit, patch, and replace methods for the given subresource | ||
| */ | ||
| EditReplacePatchable<T> subresource(String subresource); |
There was a problem hiding this comment.
nit, javadoc missing @param and @return
rohanKanojia
approved these changes
Jan 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adding a general subresource method - to make this a little cleaner the existing status specific methods are moved off of what is obtained when you call subresource or ephemeralContainers
closes #5496
Description
Type of change
test, version modification, documentation, etc.)
Checklist