fix (kubernetes-client) : Change Pod upload tarball location to target upload directory

[rohanKanojia]

Description

Fix #5527

Using /tmp as upload directory can be problematic for scenarios where /tmp is read only. We can directly upload the intermediate upload tarball to the directory where we are uploading the content.

• In case of uploading a file to a Pod, temporary tarball would be uploaded in the parent directory of that file.

• In case of uploading a directory to a Pod, temporary tarball would be uploaded in the same directory that's specified for upload path.

Other minor changes:

• Replace deprecated getNextTarEntry() with getNextEntry() in UploadTest
• Refactor getDirectoryFromFile method to reuse logic for extracting directory from file path. For consistency we always add a trailing / at the end of file path.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[shawkins]

LGTM

[manusa]

LGTM

Just to double check, are we deleting the temporary file in all cases?

[rohanKanojia]

We delete the temporary tarball after extraction:

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java

Line 173 in 272cf42

return String.format("mkdir -p %1$s; tar -C %1$s -xmf %2$s; e=$?; rm %2$s; exit $e", shellQuote(directory), tar);

If tarball upload step fails for some reason, we issue an exec to delete tarball:

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java

Lines 150 to 153 in 272cf42

	// best effort delete of the failed upload
	try (ExecWatch rm = operation.writingOutput(new ByteArrayOutputStream()).exec("sh", "-c",
	String.format("rm %s", fileName))) {
	if (!Utils.waitUntilReady(rm.exitCode(), operation.getRequestConfig().getUploadRequestTimeout(), TimeUnit.MILLISECONDS)