Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mockwebserver): DefaultMockServerTest uses Vert.x to perform verifications #5664

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Dec 20, 2023

Description

Part of #5632

Updates DefaultMockServerTest to use Vert.x instead of OkHttp to perform the verifications.

This will allow to completely remove OkHttp in a future refactor of the mockwebserver module (#5613). Having the tests in Vert.x will allow us to ensure that the functionality still works without modifying the tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.10.0 milestone Dec 20, 2023
@manusa manusa self-assigned this Dec 20, 2023
@manusa manusa force-pushed the refactor/mockwebserver-test branch 4 times, most recently from 6abb349 to 7e9315e Compare December 20, 2023 14:36
@manusa manusa force-pushed the refactor/mockwebserver-test branch from 7e9315e to 80cf43f Compare December 20, 2023 14:52
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@manusa manusa merged commit 86f544b into fabric8io:main Dec 21, 2023
17 of 19 checks passed
@manusa manusa deleted the refactor/mockwebserver-test branch December 21, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants