-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds filtering and switches to iterative traversal #5588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for sorting this out @shawkins !
I'm happy with your implementation as it looks more robust than before.
...r/api/src/main/java/io/fabric8/crd/generator/visitor/AnnotatedMultiPropertyPathDetector.java
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs 92.5% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Description
closes #5584
It doesn't seem like we need traversal below java. classes as we're only looking for our annotations. Also we can switch to an iterative traversal, which should be less likely to blow out.
cc @andreaTP
Type of change
test, version modification, documentation, etc.)
Checklist