Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc : Update CHEATSHEET with up to date examples regarding KubernetesClient (#5057) #5552

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Oct 26, 2023

Description

Fix #5057

  • Replace old get() calls with item()
  • Replace create(foo) calls with resource(foo).create()
  • Update Watcher anonymous class methods to use WatcherException instead of KubernetesClientException in onClose
  • Update updateImage() method to not use rolling() beforehand, it's not required anymore.
  • Replace client.discovery().v1beta1().endpointSlices() example with client.discovery().v1().endpointSlices()
  • Replace client.policy().podDisruptionBudget() example with client.policy().v1().podDisruptionBudget()
  • Replace client.apiextensions().v1beta1().customResourceDefinitions() example with client.apiextensions().v1().customResourceDefinitions()
  • Replace deprecated withRunConfig() call with withNewRunConfig()
  • Replace deprecated list(limit, continue) call with list(ListOptions)
  • Replace Custom Resource replaceStatus(cr) with updateStatus()
  • Replace tektonClient.v1beta1().pipelineRuns() with tektonClient.v1().pipelineRuns()
  • Remove duplicated create example of BuildConfig

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia marked this pull request as ready for review October 26, 2023 09:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@manusa manusa added this to the 6.10.0 milestone Nov 6, 2023
@manusa manusa merged commit 986157d into fabric8io:main Nov 6, 2023
18 of 21 checks passed
@rohanKanojia rohanKanojia deleted the pr/doc-5057 branch November 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Update doc/CHEATSHEET.md with up to date examples regarding KubernetesClient
3 participants