[crd-generator] Fix fallback value of Default annotation in presence of multiple accessors
#5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
requested review from
manusa,
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
andreaTP
commented
Oct 9, 2023
| @@ -558,7 +558,7 @@ public Property process() { | |||
| LOGGER.debug("Description for property {} has already been contributed by: {}", name, descriptionContributedBy); | |||
| } | |||
| } | |||
| defaultValue = p.getDefault().orElse(null); | |||
| defaultValue = p.getDefault().orElse(defaultValue); | |||
There was a problem hiding this comment.
for the records, this is the bug.
andreaTP
commented
Oct 9, 2023
| public class ZookeeperSpec { | ||
|
|
||
| @SpecReplicas | ||
| private int size; | ||
| @Required | ||
| private String version; | ||
| @Default("false") |
There was a problem hiding this comment.
Please, take note that the issue was reproducible only here.
rohanKanojia
reviewed
Oct 9, 2023
crd-generator/api/src/test/java/io/fabric8/crd/generator/v1/JsonSchemaTest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
approved these changes
Oct 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
approved these changes
Oct 16, 2023
euberseder-hubspot
added a commit
to HubSpot/kubernetes-client
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5501
Type of change
test, version modification, documentation, etc.)
Checklist