Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump com.mycila:license-maven-plugin from 3.0 to 4.3 #5483

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 27, 2023

Description

  • Bumps com.mycila:license-maven-plugin from 3.0 to 4.3.
  • Update License Maven Plugin configuration to replace legacy config excludes with licenseSets > excludes
  • Update license headers to comply with updated license maven plugin config
    • Apart from pom.xml all files contain only license related changes (i.e. comment header is updated /** to /*)

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

dependabot bot and others added 3 commits February 12, 2024 12:37
Bumps com.mycila:license-maven-plugin from 3.0 to 4.3.

---
updated-dependencies:
- dependency-name: com.mycila:license-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Move `exclude` from global configuration to `licenseSets`

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the dependabot/maven/com.mycila-license-maven-plugin-4.3 branch from dfac1f1 to 3294433 Compare February 12, 2024 07:13
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@@ -1,3 +1,18 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, while reviewing I thought it's a new license header. I will create a follow up PR to clean this up.

@@ -1,3 +1,18 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@@ -1,3 +1,18 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@manusa manusa added this to the 6.11.0 milestone Feb 12, 2024
@manusa manusa merged commit 25ecf84 into main Feb 12, 2024
16 of 19 checks passed
@manusa manusa deleted the dependabot/maven/com.mycila-license-maven-plugin-4.3 branch February 12, 2024 14:15
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this pull request Feb 12, 2024
… upgrade

Related to fabric8io#5483

After bulk update of license headers due to minor change in license
header format, some files got license header duplicated due to wrong
positioning of license header earlier.

Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this pull request Feb 12, 2024
… upgrade

Related to fabric8io#5483

After bulk update of license headers due to minor change in license
header format, some files got license header duplicated due to wrong
positioning of license header earlier.

Signed-off-by: Rohan Kumar <[email protected]>
manusa pushed a commit that referenced this pull request Feb 13, 2024
… upgrade

Related to #5483

After bulk update of license headers due to minor change in license
header format, some files got license header duplicated due to wrong
positioning of license header earlier.

Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants