Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mock Web Server migrated to this repository #5465

Merged
merged 1 commit into from
Sep 25, 2023
Merged

feat: Mock Web Server migrated to this repository #5465

merged 1 commit into from
Sep 25, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Sep 19, 2023 •
edited
Loading

Description

Part of #5430

Mock Web Server migrated to this repository

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.9.0 milestone Sep 19, 2023
@manusa manusa mentioned this pull request Sep 19, 2023
Closed
6 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2023
View reviewed changes
junit/mockwebserver/src/main/java/io/fabric8/mockwebserver/utils/SSLUtils.java
throws KeyManagementException, NoSuchAlgorithmException {
if (trustManagers == null && trustCerts) {
trustManagers = new TrustManager[] { new X509TrustManager() {
public void checkClientTrusted(X509Certificate[] chain, String s) {

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarCloud
junit/mockwebserver/src/main/java/io/fabric8/mockwebserver/utils/SSLUtils.java
public void checkClientTrusted(X509Certificate[] chain, String s) {
}

public void checkServerTrusted(X509Certificate[] chain, String s) {

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarCloud
@manusa manusa force-pushed the feat/mockwebserver branch 2 times, most recently from 8000f33 to a08013a Compare September 20, 2023 05:12
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability D 2 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

65.2% 65.2% Coverage
2.6% 2.6% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@manusa manusa merged commit 49e2d19 into fabric8io:main Sep 25, 2023
18 of 20 checks passed
@manusa manusa deleted the feat/mockwebserver branch September 25, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manusa @oscerd @rohanKanojia