Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (kubernetes-client-api) : Check KubeConfig file contents if null/empty before deserialization (#5221) #5283

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 26, 2023

Description

Fix #5221

  • Rather than directly deserializing .kube/config file content in io.fabric8.kubernetes.api.model.Config, do it only when .kube/config file content is non-blank.
  • Address cognitive complexity sonar warning in loadFromKubeconfig method

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia marked this pull request as ready for review June 27, 2023 08:27
…empty before deserialization (fabric8io#5221)

Rather than directly deserializing `.kube/config` file content in `io.fabric8.kubernetes.api.model.Config`, do it only when
`.kube/config` file content is non blank.

Signed-off-by: Rohan Kumar <[email protected]>
@manusa manusa added this to the 6.8.0 milestone Jul 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.6% 69.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@manusa manusa merged commit b81ebae into fabric8io:master Jul 6, 2023
@rohanKanojia rohanKanojia deleted the pr/issue5221 branch July 6, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty kube config(root/.kube/config) file cause NPE
3 participants