Fix #5257: Add ErrorStreamMessage and StatusStreamMessage to ease mocking of pods/exec requests

[Donnerbart]

Description

Fixes #5257

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift
• I tested my code in my own tests

[Donnerbart]

The existing classes of kubernetes-server-mock have no JavaDoc and are not mentioned in the documentation. So I guess it's okay to tick that off the checklist.

The license and spotless checks are passing locally. I guess for the SonarCloud report someone needs to trigger the builds first.

Since this is not production code, I'm not sure what to do about the I tested my code in Kubernetes/OpenShift part. I've added the same code to our custom operator to write unit tests and there it works fine.

[Donnerbart]

I think the failed SonarCloud analysis comes from a local ./mvnw clean install sonar:sonar -Psonar -DskipTests from my machine (no tests, no coverage). I'll wait until the CI runs it correctly.

[Donnerbart]

Thanks for running the tests. I don't understand the Sonar report though. It claims that there is missing code coverage on the new classes, but they are used in PodTest. Do the tests have to be in the same module to count?

[Donnerbart]

I've checked all code smells with the SonarLint plugin locally and added unit tests in the same module for all touched and new classes. Let's hope SonarCloud is happy now :)

[Donnerbart]

I've added the missing license headers to the new test files.

[Donnerbart]

Fixed the spotless violation (sorry for the many pushes, it's a totally different tech stack for me).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[shawkins]

These look much better for testing execs thank you

[Donnerbart]

I've rebased the branch to solve the conflict in the CHANGELOG.md. No further changes or merge conflicts.

Any change to get this merged into the 6.9 release?

[Donnerbart]

Looks like all E2E failed:

Error:  Failed to execute goal on project kubernetes-itests:
  Could not resolve dependencies for project io.fabric8:kubernetes-itests:jar:6.9-SNAPSHOT:
  The following artifacts could not be resolved:
  io.fabric8:kubernetes-junit-jupiter-autodetected:jar:6.9-SNAPSHOT,
  io.fabric8:openshift-client:jar:6.9-SNAPSHOT,
  io.fabric8:kubernetes-client-api:jar:tests:6.9-SNAPSHOT:
  Could not find artifact io.fabric8:kubernetes-junit-jupiter-autodetected:jar:6.9-SNAPSHOT

The PR is based on the latest main branch and I didn't change anything regarding the module setup. So I'm not sure if the root cause is in this PR or not.

[Donnerbart]

Rebased with main branch and resolved the merge conflict in CHANGELOG.md. No further changes.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here