Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: adds Javadoc entry for ServerSideApplicable#serverSideApply #5174

Merged
merged 1 commit into from
May 26, 2023
Merged

doc: adds Javadoc entry for ServerSideApplicable#serverSideApply #5174

merged 1 commit into from
May 26, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented May 25, 2023

Description

doc: adds Javadoc entry for ServerSideApplicable#serverSideApply

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa requested a review from metacosm May 25, 2023 10:17
@rohanKanojia
Copy link
Member

We should also try to update the doc/CHEATSHEET.md . It seems to be pointing to old patch method

@manusa
Copy link
Member Author

manusa commented May 25, 2023

We should also try to update the doc/CHEATSHEET.md . It seems to be pointing to old patch method

We need to remove createOrReplace entries from CHEATSHEET

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawkins
shawkins approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa added this to the 6.7.0 milestone May 26, 2023
@manusa manusa merged commit 9cbefbb into fabric8io:master May 26, 2023
@manusa manusa deleted the doc/server-side-apply branch May 26, 2023 03:57
@manusa manusa mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@shawkins shawkins shawkins approved these changes

@metacosm metacosm metacosm approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manusa @rohanKanojia @metacosm @shawkins