fix #5041: adding raw methods #5064

shawkins · 2023-04-20T18:22:34Z

Description

Fix #5041 with very simple raw method.

Some alternatives / additional work:

additionally, or instead, provide non-blocking methods
add more methods around the proxy url construction

Any scenario beyond this - requiring the manipulation of headers for example - we can direct the user to use HttpClient.

Type of change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change
Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

Code contributed by me aligns with current project license: Apache 2.0
I Added CHANGELOG entry regarding this change
I have implemented unit tests to cover my changes
I have added/updated the javadocs and other documentation accordingly
No new bugs, code smells, etc. in SonarCloud report
I tested my code in Kubernetes
I tested my code in OpenShift

manusa · 2023-04-27T09:43:08Z

kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/Client.java

+   * @param uri must start with / if relative
+   * @return the response, or null if a 404 code
+   */
+  default String raw(String uri) {


If it didn't entail a security issue I'd suggest to use URI as the parameter type instead.

manusa · 2023-04-27T09:55:13Z

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/OperationSupport.java

+      } else if (payload != null) {
+        body = Serialization.asJson(payload);
+      }
+      HttpRequest request = httpClient.newHttpRequestBuilder().uri(uri).method(method, JSON, body).build();


in relation to my previous comment about security.

In which cases do we might want to perform a request to a non-relative URL?

@shawkins, I'm going to merge as it is, but I think it's important to clarify this point. If there's no clear case, we might want to limit this to access only cluster-scoped URIs in order to prevent sending sensitive data to other locations.