Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for InputStreamReadStream NPE issue #5059

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix for InputStreamReadStream NPE issue #5059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions httpclient-vertx/src/main/java/io/fabric8/kubernetes/client/vertx/InputStreamReadStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

class InputStreamReadStream implements ReadStream<Buffer> {

private static final Buffer END_SENTINEL = Buffer.buffer();
private static final int CHUNK_SIZE = 2048;
private static final int MAX_DEPTH = 8;

Expand Down Expand Up @@ -71,7 +72,7 @@ public ReadStream<Buffer> handler(Handler<Buffer> handler) {
}
if (handler != null) {
inboundBuffer.handler(buff -> {
if (buff == null) {
if (buff == END_SENTINEL) {
if (endHandler != null) {
endHandler.handle(null);
}
Expand Down Expand Up @@ -132,7 +133,7 @@ private void readChunk2() {
// Full
}
} else {
inboundBuffer.write((Buffer) null);
inboundBuffer.write(END_SENTINEL);
}
} else {
if (exceptionHandler != null) {
Expand Down