Quantity.fromNumericalAmount, the inverse of getNumericalAmount #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuffy
requested review from
manusa,
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
|
|
||
| @Test | ||
| @DisplayName("Test fromAmountInBytes method") | ||
| public void testFromAmountInBytes() { |
There was a problem hiding this comment.
Could you please make this test parameterized instead?
There was a problem hiding this comment.
thanks for the suggestion. I made the change.
|
@rhuffy : Could you please address this minor sonar smell? |
rohanKanojia
approved these changes
Apr 19, 2023
|
Can we get another CI run on this? I believe I've fixed the test failures. |
|
bump @rohanKanojia |
|
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use getNumericalAmount to do some calculations on Quantity values as BigDecimals, and sometimes we want to convert back to a Quantity of the same units. This PR pulls the format multiplier math into a separate method and implements fromNumericalAmount as the inverse of getNumericalAmount.
Type of change
test, version modification, documentation, etc.)
Checklist