Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable Vert.x instance file caching #5044

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix: disable Vert.x instance file caching #5044

merged 1 commit into from
Apr 19, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Apr 11, 2023

Description

Disable Vert.x instance file caching

Port of quarkusio/quarkus#32502

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

shawkins
shawkins approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa added this to the 6.6.0 milestone Apr 19, 2023
@manusa manusa force-pushed the fix/disable-vertx-file-caching branch from 3bd651e to be1f542 Compare April 19, 2023 05:10
@manusa manusa force-pushed the fix/disable-vertx-file-caching branch from be1f542 to fdd8671 Compare April 19, 2023 09:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit f07dbba into fabric8io:master Apr 19, 2023
@manusa manusa deleted the fix/disable-vertx-file-caching branch April 20, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@shawkins shawkins shawkins approved these changes

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manusa @shawkins @oscerd @rohanKanojia