Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java-generator): generalized Java class generation from remote CRDs #4710

Merged
merged 4 commits into from
Dec 23, 2022

Conversation

manusa
Copy link
Member

@manusa manusa commented Dec 23, 2022

Description

Fix #4709

Generalizes the generate Java from remote URL CRD.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa force-pushed the feat/crd-downloader branch 2 times, most recently from 702ea63 to c9f9b8e Compare December 23, 2022 14:29
@manusa manusa removed the wip label Dec 23, 2022
@manusa manusa assigned andreaTP and unassigned andreaTP Dec 23, 2022
@manusa manusa requested a review from andreaTP December 23, 2022 14:29
@manusa manusa force-pushed the feat/crd-downloader branch from c9f9b8e to 031c472 Compare December 23, 2022 14:30
@manusa
Copy link
Member Author

manusa commented Dec 23, 2022

Merging this one before #4694 since it will be easier for me to rebase the other one.

@manusa
Copy link
Member Author

manusa commented Dec 23, 2022

@andreaTP please provide your thoughts either way and I'll address them in a different PR

@manusa manusa merged commit b8d2274 into fabric8io:master Dec 23, 2022
@manusa manusa deleted the feat/crd-downloader branch December 23, 2022 17:36
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

65.6% 65.6% Coverage
0.0% 0.0% Duplication

@andreaTP
Copy link
Member

andreaTP commented Jan 2, 2023

@manusa reviewing it now, I really like it thanks for the help!

@manusa manusa added this to the 6.4.0 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Generator from CRD generalized support for remote URIs
3 participants