Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk formatting and removing unused imports #4517

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 20, 2022

Description

Fix #3984 and enables removing unused imports.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

39.8% 39.8% Coverage
6.7% 6.7% Duplication

@andreaTP
Copy link
Member

Style check is failing, apart from that, now that we are at the 6.2 phase I think this does make a lot of sense 🙂
LGTM 👍

@shawkins
Copy link
Contributor Author

Style check is failing

A few old files have their header comments in the wrong spot, I'll have that addressed shortly.

@shawkins shawkins changed the title Format Bulk formatting and removing unused imports Oct 20, 2022
@andreaTP
Copy link
Member

andreaTP commented Nov 8, 2022

We should remove this line as well:

<ratchetFrom>origin/master</ratchetFrom>

@shawkins
Copy link
Contributor Author

shawkins commented Nov 8, 2022

We should remove this line as well:

@andreaTP this pr was generated with that removed

@shawkins
Copy link
Contributor Author

shawkins commented Nov 9, 2022

@andreaTP or do you mean that we shouldn't need to have that property anymore and just let it format everything on each run?

@andreaTP
Copy link
Member

andreaTP commented Nov 9, 2022

Yup, correct @shawkins

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

35.8% 35.8% Coverage
7.1% 7.1% Duplication

@shawkins
Copy link
Contributor Author

@andreaTP updated the pom to always format - it doesn't make much difference in the build time on my ssd system.

@manusa manusa added this to the 6.3.0 milestone Nov 29, 2022
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@manusa manusa merged commit 009974f into fabric8io:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk format the entire codebase
3 participants