Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes-client-api): TokenRefreshInterceptor doesn't overwrite existing OAuth token with empty string #4461

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

manusa
Copy link
Member

@manusa manusa commented Sep 29, 2022

Description

Fix #4442
fix(kubernetes-client-api): TokenRefreshInterceptor doesn't overwrite existing OAuth token with empty string

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member Author

manusa commented Sep 29, 2022

Some other test might be messing up the new tests.
I can't reproduce the test failure locally even if I run the suite continuously thousands of times either via Maven or the IDE.

… existing OAuth token with empty string

Signed-off-by: Marc Nuri <[email protected]>
@manusa manusa merged commit ad7c825 into fabric8io:master Sep 29, 2022
@manusa manusa deleted the fix/token-refresh branch September 29, 2022 13:26
@manusa manusa added the 5.12.x Backportable tentative label Sep 29, 2022
@manusa manusa added this to the 6.2.0 milestone Sep 29, 2022
@manusa manusa removed the 5.12.x Backportable tentative label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TokenRefreshInterceptor overwrites Oauth token to empty string
3 participants