Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fabric8NameHelper renames fields with reserved keywords #4358

Merged
merged 1 commit into from
Aug 29, 2022
Merged

chore: Fabric8NameHelper renames fields with reserved keywords #4358

merged 1 commit into from
Aug 29, 2022

Conversation

manusa
Copy link
Member

@manusa manusa commented Aug 29, 2022 •
edited
Loading

Description

chore: Fabric8NameHelper renames fields with reserved keywords

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa requested a review from rohanKanojia August 29, 2022 10:06
@manusa manusa self-assigned this Aug 29, 2022
@manusa manusa force-pushed the chore/name-strategy branch from 774f716 to 94b4cf0 Compare August 29, 2022 10:27
@manusa manusa marked this pull request as ready for review August 29, 2022 10:29
@manusa manusa added this to the 6.1.0 milestone Aug 29, 2022
@manusa manusa force-pushed the chore/name-strategy branch from 94b4cf0 to 989d204 Compare August 29, 2022 11:12
@manusa manusa mentioned this pull request Aug 29, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 6f76d79 into fabric8io:master Aug 29, 2022
@manusa manusa deleted the chore/name-strategy branch August 29, 2022 12:38
@manusa manusa mentioned this pull request Aug 29, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manusa @rohanKanojia